Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss/sairedis #1527
+855
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -2618,6 +2819,171 @@ | |||
| notifyPoll(); | |||
| } | |||
|
|
|||
| void FlexCounter::bulkAddCounter( | |||
Check notice
Code scanning / CodeQL
Irregular enum initialization Note
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
bulk-counter-init
branch
from
d2a613b to
ad06ae8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
the failure is not relevant to the commits |
keboliu
approved these changes
Feb 13, 2025
kcudnik
reviewed
Feb 13, 2025
kcudnik
reviewed
Feb 13, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
bulk-counter-init
branch
from
11034f3 to
fe9a9be
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
previously approved these changes
Feb 16, 2025
All counters are created in bulk mode. We should translate bulkAddObject to iteration of single call (addObject) for counter groups that do not support bulk. Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @kcudnik would you please review it again and merge it if no comments? fix an issue since last approval and also add ut to cover it. |
kcudnik
approved these changes
Feb 19, 2025
stephenxs
added
Request for msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
Request for msft-202412 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization.
Originally,
orchagentnotifiessyncdto initialize the counter using an extended sairedis callSAI_REDIS_SWITCH_ATTR_FLEX_COUNTERfor each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls.Now, for counter groups that have many objects (e.g., port, PG, queues, etc),
orchagentnotifiessyncdto initialize the counter using a single extend sairedis call with many objects' ID as the key (format:<key1>,<key2>,...<keyn>). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required.Details:
In sairedis, the bulk counter is supported for all counter groups except
Buffer Pool CounterandDASH ENI counter.In swss, bulk counter for the following counter groups
HLD sonic-net/SONiC#1862